ssh: Fix keepalive response stealing channel open requests#11205
Open
u3s wants to merge 1 commit into
Open
Conversation
Contributor
CT Test Results 2 files 29 suites 25m 35s ⏱️ Results for commit 53b994b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
u3s
force-pushed
the
kuba/ssh/fix-global-request-race/OTP-20181
branch
from
ce21075 to
2337bd6
Compare
Contributor
Author
|
FYI, @alexandrejbr |
A keepalive response (ssh_msg_request_success) could consume a pending channel open entry from the shared requests queue, causing the channel setup to fail silently with a timeout. Replace positional head-matching of the requests list with take_global_request/1 that selects entries by reference key, skipping integer-keyed channel entries. Register keepalive probes in the queue so their responses are properly consumed.
u3s
force-pushed
the
kuba/ssh/fix-global-request-race/OTP-20181
branch
from
2337bd6 to
53b994b
Compare
Mikaka27
approved these changes
Jun 8, 2026
Contributor
Mikaka27
left a comment
Mikaka27
left a comment
There was a problem hiding this comment.
Looks good, but let's wait for results from CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A keepalive response (ssh_msg_request_success) could consume a pending channel open entry from the shared requests queue, causing the channel setup to fail silently with a timeout.
Replace positional head-matching of the requests list with take_global_request/1 that selects entries by reference key, skipping integer-keyed channel entries. Register keepalive probes in the queue so their responses are properly consumed.